feat(gradle-plugin): enable lazy evaluation, implicit task dependencies and fixing setEncoding
#4761
+299
−294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbrugger-tgm
changed the title
setEncoding
nbrugger-tgm
force-pushed
the
gradle/enable-lazy-configuration
branch
from
140edb6
to
57c56d2
Compare
changes:
- enable lazy evaluation by
- replacing all Task configurations with gradles Property types
- using `register` instead of `create` to register the task
- remove wrongly set task dependencies that can cause circular dependencies. Task dependencies are now inferred by the set classpath. When gradle detects that an output of a task (like compileJava) is used an automatic dependency is formed and `resolve` will always execute compileJava first. The advantage is that this is dynamic. If one does NOT want `compileJava` to be executed it won't be as soon as nothing of compileJava is on the configured classpath
nbrugger-tgm
force-pushed
the
gradle/enable-lazy-configuration
branch
from
57c56d2
to
b7d4a37
Compare
|
Sorry for the force pushes, i had to fix the commit it had the wrong commiter was not signed and i messed up the commit message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Changes
registerinstead ofcreateto register the taskresolvewill always execute compileJava first. The advantage is that this is dynamic. If one does NOT wantcompileJavato be executed it won't be as soon as nothing of compileJava is on the configured classpath